logo

eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 909
quick edit when not logged in

I am currently logged in on FF

I check posts on another browser (should not matter which one)
I am guest (cos I not log in on that one yet) but I can see "modify post, and can click it too, it works, but I will not post it, except this once Smile (see layout issues)

note: quick edit not "fixed" for gecko engine (khtml) (the & problem)

edit: I will also test this from another machine I have on the network here (in case you are storing my router IP)

eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 1528
Re: new bug

Yes i think its because the IP Address stored by the post is the same as yours and because you are a guest you can still edit it, im going to see if i can stop it doing that for posts created by non-guests

Please do not PM me requesting support or anything, use the forums, thats what they are here for
eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 909
Re: new bug

the other way is to set a cookie, if no cookie, no logged on, no problem

eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 909
Re: new bug

as far as IP goes, any of these other network machines will actually supply a slightly different address, but only in X-FORWARD-FOR (you will need to check headers to see exactly which ones are set - I have an output page if you need one, checks three variable arrays)

eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 1528
Re: new bug

Well this is what i use for the IP Address
Code:
  function visitor_ip() {
$ip=$_SERVER['REMOTE_ADDR']==$_SERVER['SERVER_ADDR'] && isset($_SERVER['HTTP_X_FORWARDED_FOR']) ? $_SERVER['HTTP_X_FORWARDED_FOR'] : $_SERVER['REMOTE_ADDR'];
return $ip;
}

Please do not PM me requesting support or anything, use the forums, thats what they are here for
eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 909
Re: new bug

do you have a db viewer, my X-FORWARD-FOR is 220.244.144.143

eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 1528
Re: new bug

what do you mean db viewer?

Edit: Hope you dont mind, i changed the topic title to describe what the actual bug is Wink

Please do not PM me requesting support or anything, use the forums, thats what they are here for
eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 909
Re: quick edit when not logged in

can you view raw/actual db entries

BTW, I logged out of FF, the started KHTML, guess what I could see on my posts (before I logged in)

edit: yeah it works the other way too. do you clear the cookie when user logs out

eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 1528
Re: quick edit when not logged in

The quick edit icon? Looking into that now

Please do not PM me requesting support or anything, use the forums, thats what they are here for
eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 909
Re: quick edit when not logged in

maybe (if not just by clearing it) need to rethink "we know your on key", maybe hash/md5 with logon time.

as long as there is not a check for the IP after logoff and cookie cleared, should be no problermo..

BTW this time when I logged off in FF, I did not get kicked in KHTML (were I'm still logged on) this is good, it should be per browser

eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 1528
Re: quick edit when not logged in

I think it would be more secure to MD5 the session_id stored in the Cookie but a PHPSESSID cookie gets created anyway which would kind of defy the purpose

Please do not PM me requesting support or anything, use the forums, thats what they are here for
eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 1528
Re: quick edit when not logged in

Ok does it still do this now?

Please do not PM me requesting support or anything, use the forums, thats what they are here for
eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 909
Re: quick edit when not logged in

nope sorry, still does it, and I shut the windows too, maybe I will try closing browser too (soon, not right now)

eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 1528
Re: quick edit when not logged in

How about now? I just tested it and i cant see either the quick edit nor the edit link when not logged in now

Please do not PM me requesting support or anything, use the forums, thats what they are here for
eoCMS Designer
eoCMS Designer
Offline Offline
avatar
Posts: 1290
tbarkass_willamson@hotmail.com
Re: quick edit when not logged in

I get the same thing as confuser :S

Seen a bug? Report it!
eoCMS Developer
eoCMS Developer
Offline Offline
avatar
Posts: 909
Re: quick edit when not logged in

yep, I think this might be fixed now...

eoCMS Designer
eoCMS Designer
Offline Offline
avatar
Posts: 1290
tbarkass_willamson@hotmail.com
Re: quick edit when not logged in

OK I'll call it fixed and we can unlock it if necessary.

Seen a bug? Report it!

Jump to:


0.13 seconds Queries: 13